[docType] Use slashstar for groovy, kotlin, and scala as proper usage #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to align with java usage. All three were confirmed that they should be slash star.
|
@mathieucarbou If you look at these three language types on github, each have their own source files for the language types using slash star now. |
mathieucarbou
approved these changes
Sep 18, 2020
|
this will break backward compatibility, but I think this is ok for version 4. This will be in release |
|
@mathieucarbou Correct, same breaking change that was done with java so it matches. |
uyw4687
added a commit
to uyw4687/license-maven-plugin
that referenced
this pull request
Sep 18, 2023
If you see examples in java, kotlin, etc., they mostly have newline after the copyright statement. mathieucarbou#186 It might be because Intellij applies header file in that way and also because in this way this would be easier to divide copyright and the code. Since customizing the headerDefinition regarding ending newline makes a quite long configuration having to reconfigure all other values, making it default might be better ƒor this plugin to be used more commonly.
uyw4687
added a commit
to uyw4687/license-maven-plugin
that referenced
this pull request
Sep 18, 2023
If you see examples in java, kotlin, etc., they mostly have newline after the copyright statement. mathieucarbou#186 It might be because Intellij applies header file in that way and also because in this way this would be easier to divide copyright and the code. Since customizing the headerDefinition regarding ending newline makes a quite long configuration having to reconfigure all other values, making it default might be better ƒor this plugin to be used more commonly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These need to align with java usage. All three were confirmed that they should be slash star.