Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underscore in java package name #187

Closed
jam01 opened this issue Sep 28, 2020 · 1 comment · Fixed by #221
Closed

underscore in java package name #187

jam01 opened this issue Sep 28, 2020 · 1 comment · Fixed by #221
Assignees
Labels
in:core MLP core module is:bug Bugs to fix
Milestone

Comments

@jam01
Copy link

jam01 commented Sep 28, 2020

According to https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html underscores can be expected in package names. The JAVAPKG style first line pattern does not include underscore and so the license is not applied properly.

Suggesting changing
"^package [a-z]+(\\.[a-z][a-z0-9]*)*;$" to "^package [a-z_]+(\\.[a-z_][a-z0-9_]*)*;$"
I can propose a PR, just wanted to make sure the general idea was agreed upon :)

@stale
Copy link

stale bot commented Sep 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive items that will be automatically closed if not resurrected label Sep 7, 2021
@mathieucarbou mathieucarbou self-assigned this Sep 7, 2021
@stale stale bot removed the stale Inactive items that will be automatically closed if not resurrected label Sep 7, 2021
@mathieucarbou mathieucarbou added is:bug Bugs to fix stale Inactive items that will be automatically closed if not resurrected todo Accepted items from the backlog which can be worked on labels Sep 7, 2021
@stale stale bot removed the stale Inactive items that will be automatically closed if not resurrected label Sep 7, 2021
@mathieucarbou mathieucarbou added this to the 4.2 milestone Sep 7, 2021
@mathieucarbou mathieucarbou removed their assignment Sep 7, 2021
@mathieucarbou mathieucarbou added the in:core MLP core module label Sep 8, 2021
@mathieucarbou mathieucarbou self-assigned this Sep 11, 2021
mathieucarbou added a commit that referenced this issue Sep 11, 2021
@mathieucarbou mathieucarbou linked a pull request Sep 11, 2021 that will close this issue
@mathieucarbou mathieucarbou removed the todo Accepted items from the backlog which can be worked on label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:core MLP core module is:bug Bugs to fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants