Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird results when combining -script and -e #1455

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix weird results when combining -script and -e #1455

merged 2 commits into from
Jun 29, 2021

Conversation

TiagoCavalcante
Copy link
Contributor

Fixes #712.

test/data/script.m Outdated Show resolved Hide resolved
Copy link
Member

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TiagoCavalcante
Copy link
Contributor Author

Looks like that capture_output was added in Python 3.7.

@rocky
Copy link
Member

rocky commented Jun 28, 2021

Looks like that capture_output was added in Python 3.7.

I guess we can skip the test when Python < 3.7.

@TiagoCavalcante
Copy link
Contributor Author

Ok, how I do it?

I thought in jump the assert if the version (which I was going to get by os module) is smaller than 7, but I guess there's a better way.

@rocky
Copy link
Member

rocky commented Jun 28, 2021

Ok, how I do it?

I thought in jump the assert if the version (which I was going to get by os module) is smaller than 7, but I guess there's a better way.

See

https://stackoverflow.com/questions/38442897/how-do-i-disable-a-test-using-pytest#:~:text=Skipping%20a%20test%20based,or%20higher%22)%0Adef%20test_func_one()%3A%0A%20%20%20%20...

test/test_cli.py Outdated Show resolved Hide resolved
@rocky rocky merged commit 4af8a3e into mathics:master Jun 29, 2021
@TiagoCavalcante TiagoCavalcante deleted the fix-712 branch June 29, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--execute does not work as expected
2 participants