-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an option for use Asymptote to build svg graphics #1145
Changes from 13 commits
cef9469
18d9c3d
6b52d26
3eaa4ca
4edae89
7857d42
12fea19
b896993
b97bbb9
3ad44bc
a4d8ec5
9079351
15216ae
e21f49b
08d4b63
4b4ddb3
108dfc3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2137,7 +2137,7 @@ def __neg__(self) -> 'Rational': | |
|
||
@property | ||
def is_zero(self) -> bool: | ||
return self.numerator().is_zero and not self.denominator().is_zero() | ||
return self.numerator().is_zero and not(self.denominator().is_zero) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be in a separate PR. It fixes a current bug and is not specific to asymptote, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I put this because I got CI errors due to PossibleZeroQ. I removed this change from this PR. Please look at #1164. |
||
|
||
class Real(Number): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a parameter like this feels really hacky.
The front end should be involved here. The backend merely needs to provide the underlying building blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but for it, I would need to merge #1140 first...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until #1140 clears then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of these modifications is to have a working graphics engine without changing the current core. Most of the code is there, and if the control variable is not set (or set to false), we get the previous (buggy) behavior.
On the other hand, this does not clash against #1140, this is why I put this in a separated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.