Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name collision #97

Open
joeyhub opened this issue Sep 11, 2019 · 3 comments
Open

Name collision #97

joeyhub opened this issue Sep 11, 2019 · 3 comments

Comments

@joeyhub
Copy link

joeyhub commented Sep 11, 2019

This package uses the same name as the inbuilt punycode package in node.js.

While this might work with the default loader (haven't tried), it can cause an annoyance for package builders (some seem to ignore it as a build in).

Any chance of being able to alias it?

@SukkaW
Copy link

SukkaW commented Dec 1, 2019

Currently I am facing the same issue. Although I have installed the package through npm i punycode, but eslint continues to tells me that 'punycode' module was deprecated since v7.

And I have found this: https://www.npmjs.com/package/punycode.js . punycode.js is exactly the same as punycode which could avoid the case.

@nbouvrette
Copy link

Unfortunately npm i --save-dev @types/punycode.js fails so there is no way to get proper typing with punycode.js

@milahu
Copy link

milahu commented Feb 15, 2024

https://www.npmjs.com/package/punycode

Note that userland modules don't hide core modules. For example, require('punycode') still imports the deprecated core module even if you executed npm install punycode. Use require('punycode/') to import userland modules rather than core modules.

const punycode = require('punycode/');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants