Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use alias package punycode.js #146

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Dec 1, 2019

punycode package uses the same name as the inbuilt punycode package in node.js. Related report can be found here.

And I have found the package punycode.js on npm. It is exact the same package as punycode and has the same maintainer, which could act as an alias to punycode. The only difference between them is punycode package has added es6 module support in [email protected].

@SukkaW SukkaW requested a review from curbengh December 1, 2019 07:08
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 96.647% when pulling 4af01e7 on SukkaW:deps-punycode into ea43fba on hexojs:master.

@curbengh
Copy link
Contributor

curbengh commented Dec 1, 2019

whatwg has built-in punycode support, but it's not used here yet due to a bug in Node 8. Once Node 8 EOL (in a month), punycode shall be dropped.

// TODO: refactor to url.format() once Node 8 EOL
return parsed.toString().replace(parsed.hostname, toUnicode(parsed.hostname));

@tomap tomap merged commit e4eb60a into hexojs:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants