Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes server errors when RPC exceptions are thrown while rendering common_data #3948

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

pavish
Copy link
Member

@pavish pavish commented Oct 10, 2024

Fixes #3903

This PR fixes a few bugs that arise due to RPC exceptions while rendering common_data:

  • 500 while starting Mathesar when only one database is present and the admin is not a collaborator on it.
  • 500 when opening urls for objects that're not present such as /db/10000/schemas or /db/10000/schemas/12000/ (assuming the database 10000 and schema 12000 are not present).
    • Note: This happens when directly modifying the browser url.
  • 500 when opening a url for a database that the Mathesar admin is not a collaborator of.
    • Note: This happens when directly modifying the browser url.

The PR also removes the shares urls since I didn't want to spend time refactoring them.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish changed the title Fixes server errors when RC] Fixes server errors when RPC exceptions are thrown while rendering common_data Oct 10, 2024
@pavish pavish requested review from mathemancer and seancolsen and removed request for mathemancer October 10, 2024 07:53
@pavish pavish added the pr-status: review A PR awaiting review label Oct 10, 2024
@pavish pavish added this to the v0.2.0-testing.1 milestone Oct 10, 2024
@pavish pavish requested a review from mathemancer October 10, 2024 13:36
@seancolsen seancolsen removed their assignment Oct 10, 2024
@pavish pavish assigned Anish9901 and unassigned mathemancer Oct 10, 2024
@pavish pavish requested a review from Anish9901 October 10, 2024 14:02
@kgodey kgodey changed the base branch from develop to 0.2.0-testing.1 October 10, 2024 14:09
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anish9901 Anish9901 merged commit fe1e672 into 0.2.0-testing.1 Oct 11, 2024
36 checks passed
@Anish9901 Anish9901 deleted the fix-500-commondata branch October 11, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server error (500) when there's a single database connected and admin user is not a collaborator
4 participants