Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces frontend caching, fixes a few bugs #3897

Merged
merged 17 commits into from
Oct 1, 2024
Merged

Reduces frontend caching, fixes a few bugs #3897

merged 17 commits into from
Oct 1, 2024

Conversation

pavish
Copy link
Member

@pavish pavish commented Sep 30, 2024

Fixes #3864
Fixes #3877
Reduces frontend caching: Only caches current schema, tables, and explorations
Fixes duplicate requests for databases.get
Fixes common data: Null scenarios, removes abstract types
Fixes some minor translation issues (see commits)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish changed the title Reduces frontend caching, Reduces frontend caching, fixes a few bugs Sep 30, 2024
@pavish pavish requested a review from seancolsen September 30, 2024 14:26
@pavish pavish added the pr-status: review A PR awaiting review label Sep 30, 2024
@pavish pavish added this to the v0.2.0-testing.1 milestone Sep 30, 2024
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great. I like how the changes in stores/* simplify a lot of things!

Instead of requesting changes, I just made them myself, and I'll kick this back to you to look over before merging. If you don't like my changes, we can continue discussing. Or if you're cool with this, then feel free to merge.

There was some naming I didn't like, so I pushed 2c39ff9 to adjust it.

Those naming changes also led me to dig deeper into AsyncRpcApiStore.runBatched because I especially didn't like using the word "optimal" to refer to the logic of running something only when it's not initialized. The word "optimal" made me think it would always run but that it would do so using some special heuristics like compression or something. I think "conservative" is a better word (though not perfect) to indicate that it will happen only when necessary.

Also, we don't currently have a need for AsyncRpcApiStore to handle arrays of BatchRunners with different modes. If we did have such a need, then passing an array of runners alongside an array of options would seem messy and hard to read because the options would not be lined up directly with their runners. This is the sort of code that I would not love:

AsyncRpcApiStore.runBatch(
  [
    foo.batchRunner({ a: 1 }),
    bar.batchRunner({ b: 2 }),
  ],
  { mode: [ 'force-run', 'optimal' ] }
);

If we do eventually have a need for one batch with different modes like that, then I'd rather make some minor modifications to allow calling code that would look something like this:

AsyncRpcApiStore.runBatch([
  foo.batchRunner({ a: 1 }),
  bar.conservativeBatchRunner({ b: 2 }),
]);

But we don't even have that need yet, so I think it's best to err on the side of simplicity and only support batching via homogeneous modes.

@seancolsen seancolsen assigned pavish and unassigned seancolsen Sep 30, 2024
@seancolsen seancolsen added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Sep 30, 2024
@pavish
Copy link
Member Author

pavish commented Oct 1, 2024

Thanks @seancolsen!

I think the name changes make sense.

I added two small commits.

  • 4291b3b to make the logic consistent between runConservatively and runBatchConservatively.
  • 98e48ea to run side effects when the logged in user adds themselves as a collaborator.

I'm going to merge this PR in since the commits are fairly minor. Please feel free to take a look and review retroactively.

@pavish pavish enabled auto-merge October 1, 2024 08:36
@pavish pavish added this pull request to the merge queue Oct 1, 2024
Merged via the queue into develop with commit a41e2fb Oct 1, 2024
36 checks passed
@pavish pavish deleted the handle-caching branch October 1, 2024 08:58
@seancolsen seancolsen mentioned this pull request Oct 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
None yet
2 participants