Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic Table data model on the frontend and Table Permissions modal -> 'Share' tab #3838

Merged
merged 13 commits into from
Sep 18, 2024

Conversation

pavish
Copy link
Member

@pavish pavish commented Sep 16, 2024

Related to: #3686
Fixes #3812

This PR:

  • Implements a basic Table data model.
    • This modal does not have stores for properties that can be updated such as name, description, etc., for the sake of speed. We will be updating it after Beta.
  • Implements the Permissions modal -> 'Share' tab for tables.
  • Hides the 'Share' button for public sharing in both Table and Exploration Page

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish changed the base branch from develop to permissions-modals-1 September 16, 2024 12:52
Base automatically changed from permissions-modals-1 to develop September 16, 2024 16:38
@pavish pavish changed the title Implement basic Table data model on the frontend Implement basic Table data model on the frontend and Table Permissions modal -> 'Share' tab Sep 18, 2024
@pavish pavish marked this pull request as ready for review September 18, 2024 12:18
@pavish pavish requested a review from seancolsen September 18, 2024 12:18
@pavish pavish added the pr-status: review A PR awaiting review label Sep 18, 2024
@kgodey kgodey added this to the Pre-beta test build #1 milestone Sep 18, 2024
@kgodey
Copy link
Contributor

kgodey commented Sep 18, 2024

@pavish I added the milestone to the PR, please make sure to do that for future PRs.

@seancolsen
Copy link
Contributor

Heads up that in 08003c1 I resolved some merge conflicts in ExtractColumnsModal.svelte

Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome that you implemented the Table model!

@seancolsen seancolsen added this pull request to the merge queue Sep 18, 2024
Merged via the queue into develop with commit f8b81c2 Sep 18, 2024
33 checks passed
@seancolsen seancolsen deleted the permissions-modals-2 branch September 18, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement public shares related changes - Hide sharing UI
3 participants