Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-code type cast map on front end #3832

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Hard-code type cast map on front end #3832

merged 2 commits into from
Sep 16, 2024

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Sep 13, 2024

Stacked on #3819

As discussed today, the front end needs a way to know which types a column can be cast to. On that call, @Anish9901 and I had originally decided to build an API for this. However @Anish9901 later decided it would be better to hard-code this cast mapping on the front end, at least for now. This PR implements that hard-coding strategy, which allows the type of columns to be changed again.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the Beta milestone Sep 13, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Sep 13, 2024
Base automatically changed from import_fe to develop September 16, 2024 05:55
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pavish pavish enabled auto-merge September 16, 2024 13:05
@pavish pavish added this pull request to the merge queue Sep 16, 2024
Merged via the queue into develop with commit 4d79e08 Sep 16, 2024
33 checks passed
@pavish pavish deleted the target_types_fe branch September 16, 2024 13:25
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants