-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate RPC record summary changes to front end #3811
Conversation
/** | ||
* When true, load the record summaries associated directly with each record | ||
* in the table. These are *not* the record summaries associated with linked | ||
* records. Instead they are the summaries of the records themselves. By | ||
* default, we don't load these summaries because it's a performance hit. But | ||
* we need them for the records within the record selector. | ||
*/ | ||
loadIntrinsicRecordSummaries?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seancolsen The only place we seem to require intrinsic record summaries is when selecting a record via the record selector which updates a cell in the parent table. However, the RPC method records.patch
already returns the required record summary within linked_record_summaries
. Could we use that directly instead of requesting the intrinsic record summaries?
It is possible that I may not be seeing additional places/cases where this is required. If so, could you specify where/why we need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. I see that we close the Record selector immediately after picking the record, and the summary is required while the parent record is being saved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Notes
The corresponding back end PRs are:
This PR removes quite a bit of code because previously record summaries were being rendered on the front end in several places by taking the fields + the template to produce a string. Now the architecture is much simpler, doing all the rendering on the backend.
Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin