Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Records delete bugfix #3754

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Records delete bugfix #3754

merged 2 commits into from
Aug 13, 2024

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Aug 13, 2024

Fixes #3752

This PR lets the caller submit record IDs to be deleted in any type, and then coerces them to text (along with the actual primary key column) before comparing in the DELETE's WHERE clause.

Technical details

A side-effect of this PR is that we can no longer support some more exotic primary key column types (e.g., composite types, array types), whereas the previous version would have.

We consider this to be a reasonable compromise at the moment, since we don't really officially support tables with non-integer primary keys anyway. However, because the new behavior is a bit inconsistent (and may be confusing), we should readdress this at some point, and try to come up with a better solution.

Note that we do not coerce the submitted keys to the type of the primary key column, since that conversion could be lossy, and result in deleting more records than intended.

When submitting primary keys to which we apply custom formatting (e.g., datetime types), they should be formatted when submitted.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer changed the base branch from develop to records_grouping_bugfix August 13, 2024 07:00
@mathemancer mathemancer requested a review from Anish9901 August 13, 2024 07:11
@mathemancer mathemancer requested a review from seancolsen August 13, 2024 07:11
@mathemancer mathemancer added this to the Beta milestone Aug 13, 2024
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Aug 13, 2024
@mathemancer
Copy link
Contributor Author

@Anish9901 This shouldn't be merged until after #3751 .

Base automatically changed from records_grouping_bugfix to develop August 13, 2024 14:53
@seancolsen
Copy link
Contributor

Front end counterpart: #3757

@seancolsen seancolsen removed their assignment Aug 13, 2024
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@seancolsen seancolsen added this pull request to the merge queue Aug 13, 2024
@seancolsen
Copy link
Contributor

Even though @Anish9901 hasn't yet reviewed, I'm merging this because I have a bunch of other work that I'd like to stack on top of it so that it's easier for Pavish to review while I'm gone.

If we need to make changes later, I figure we can do those in a follow-up PR.

Merged via the queue into develop with commit c6ba8de Aug 13, 2024
33 checks passed
@seancolsen seancolsen deleted the records_delete_bugfix branch August 13, 2024 18:15
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify records.delete RPC method to permit deleting records via stringified primary key values
4 participants