Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial database_setup RPC functions #3665

Merged
merged 17 commits into from
Jul 12, 2024
Merged

Initial database_setup RPC functions #3665

merged 17 commits into from
Jul 12, 2024

Conversation

mathemancer
Copy link
Contributor

Fixes #3654
Fixes #3655
Fixes #3656

This adds database_setup.create_new, database_setup.connect_existing, and databases.list RPC functions.

Technical details

Note that while this PR doesn't actually break anything, it does remove some functionality from the connections RPC functions. I think that's okay, since we'll be replacing those.

All RPC functions are documented, and the documentation should be sufficient to understand them. If not, we need to improve the docs before merging this PR.

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer requested review from Anish9901 and pavish July 8, 2024 10:24
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Jul 8, 2024
@mathemancer mathemancer added this to the Beta milestone Jul 8, 2024
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pavish pavish removed their assignment Jul 9, 2024
@pavish pavish mentioned this pull request Jul 11, 2024
7 tasks
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall @mathemancer, I've pointed out a minor bug please see the specific comment below.

name=role_name,
server=server,
defaults={"password": password},
)
return UserDatabaseRoleMap.objects.create(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws up an IntegrityError when we try to add the existing credentials via the API, I think we ought to use get_or_create here as well, to ensure that we allow users to reinstall mathesar even if the database gets deleted outside of mathesar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with that change.

@mathemancer mathemancer requested a review from Anish9901 July 12, 2024 14:09
@mathemancer
Copy link
Contributor Author

@Anish9901 Ready for re-review

Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @mathemancer, Thanks!

@Anish9901 Anish9901 enabled auto-merge July 12, 2024 14:13
@Anish9901 Anish9901 added this pull request to the merge queue Jul 12, 2024
Merged via the queue into develop with commit f98dfe0 Jul 12, 2024
39 checks passed
@Anish9901 Anish9901 deleted the init_db_rpc branch July 12, 2024 14:36
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databases.list database_setup.create_new database_setup.connect_existing
4 participants