Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire RPC functions to new models #3632

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Conversation

mathemancer
Copy link
Contributor

Fixes #3631

This is a small PR that changes the connection logic for RPC functions to use the new models. It also adds a (maybe temporary) RPC function to easily migrate a deprecated Connection to the new setup, and give an identified user access to the associated map entry.

Technical details

Merging this PR will require developers to run the migration function in order to test the other RPC functions, since it replaces the connection "always allowed" logic with something more robust.

I think we should merge it in case someone somewhere is using our develop branch for something with sensitive data.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer requested a review from Anish9901 June 18, 2024 08:56
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Server model also have a unique constraint on host and port? I think I missed this in my review of the last PR. This PR looks great otherwise.

Comment on lines 8 to 10
Args:
conn_id: The Django id corresponding to the Connection.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these args as well.

@mathemancer mathemancer requested a review from Anish9901 June 18, 2024 13:47
@Anish9901 Anish9901 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into develop with commit 531d7db Jun 18, 2024
37 checks passed
@Anish9901 Anish9901 deleted the permission_remodel_wire_rpc branch June 18, 2024 18:42
@kgodey kgodey added this to the Pre-beta test build #1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wire RPC functions to new permissions models
3 participants