-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire RPC functions to new models #3632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the Server
model also have a unique constraint on host
and port
? I think I missed this in my review of the last PR. This PR looks great otherwise.
mathesar/rpc/utils.py
Outdated
Args: | ||
conn_id: The Django id corresponding to the Connection. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update these args as well.
Fixes #3631
This is a small PR that changes the connection logic for RPC functions to use the new models. It also adds a (maybe temporary) RPC function to easily migrate a deprecated
Connection
to the new setup, and give an identified user access to the associated map entry.Technical details
Merging this PR will require developers to run the migration function in order to test the other RPC functions, since it replaces the connection "always allowed" logic with something more robust.
I think we should merge it in case someone somewhere is using our develop branch for something with sensitive data.
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin