-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tables.patch
RPC endpoint
#3618
Conversation
table.patch
RPC endpointtables.patch
RPC endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks good, with the exception of a small docstring issue. Please merge once that's fixed along with the merge conflict. Re-request review if you think it's needed.
db/sql/00_msar.sql
Outdated
-- Alter table ------------------------------------------------------------------------------------- | ||
CREATE OR REPLACE FUNCTION | ||
msar.alter_table(tab_id oid, tab_alters jsonb) RETURNS text AS $$/* | ||
Alter columns of the given table in bulk, returning the IDs of the columns so altered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't accurate. It returns the name of the table.
Fixes #3617
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin