Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor list of RPC methods to test #3597

Merged
merged 1 commit into from
May 20, 2024
Merged

Refactor list of RPC methods to test #3597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 18 additions & 30 deletions mathesar/tests/rpc/test_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,22 @@
from mathesar.rpc import connections


exposed_functions = [
"columns.list",
"connections.add_from_known_connection",
"connections.add_from_scratch",
METHODS = [
(
columns.list_,
"columns.list",
[user_is_authenticated]
),
(
connections.add_from_known_connection,
"connections.add_from_known_connection",
[user_is_superuser]
),
(
connections.add_from_scratch,
"connections.add_from_scratch",
[user_is_superuser]
)
]


Expand All @@ -31,34 +43,10 @@ def test_rpc_endpoint_expected_methods(live_server, admin_client):
content_type="application/json"
).json()["result"]
mathesar_methods = [m for m in all_methods if not m.startswith("system.")]
expect_methods = [
"columns.list",
"connections.add_from_known_connection",
"connections.add_from_scratch",
]
assert sorted(mathesar_methods) == expect_methods
assert sorted(mathesar_methods) == sorted(m[1] for m in METHODS)


@pytest.mark.parametrize(
"func,exposed_name,auth_pred_params",
[
(
columns.list_,
"columns.list",
[user_is_authenticated]
),
(
connections.add_from_known_connection,
"connections.add_from_known_connection",
[user_is_superuser]
),
(
connections.add_from_scratch,
"connections.add_from_scratch",
[user_is_superuser]
)
]
)
@pytest.mark.parametrize("func,exposed_name,auth_pred_params", METHODS)
def test_correctly_exposed(func, exposed_name, auth_pred_params):
"""Tests to make sure every RPC function is correctly wired up."""
# Make sure we didn't typo the function names for the endpoint.
Expand Down
Loading