Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead front end API client code to GET one schema #3589

Merged
merged 1 commit into from
May 15, 2024

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented May 15, 2024

I found this dead code, so I'm removing it myself without review. This helps us better organize our RPC API transition because it's clearer what code usage we have for our REST endpoints. We're not implementing any RPC functions for unused REST endpoints / HTTP methods. Removing this dead frontend code makes it clearer that we don't need to implement a schemas.get RPC function.

@pavish heads up about this. You might wish to take a quick glance.

Wiki edit which removes this entry from our to-do list.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the Beta milestone May 15, 2024
@seancolsen seancolsen enabled auto-merge May 15, 2024 01:25
seancolsen added a commit to mathesar-foundation/mathesar-wiki that referenced this pull request May 15, 2024
Front end code is not actually used. Dead code removed in:
mathesar-foundation/mathesar#3589
@seancolsen seancolsen added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit 4e28306 May 15, 2024
33 checks passed
@seancolsen seancolsen deleted the remove_schemas_get branch May 15, 2024 02:12
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants