Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections RPC front end #3543

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Connections RPC front end #3543

merged 7 commits into from
Apr 30, 2024

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Apr 17, 2024

In #3524, we added the following RPC APIs on the backend:

  • connections.add_from_known_connection
  • connections.add_from_scratch

This PR changes the front end to use those new RPC APIs.

In doing so, it also adds a new general-purpose utility, which I named json-rpc-client-builder. This code is Mathesar-agnostic, so I put it into a new place in our codebase — a packages directory. See the README.md files for more info.

The Mathesar-specific code for these new API methods is is src/api/rpc/ and you'll notice it's quite small. By following the pattern established here, we'll be able to implement the client side of new RPC methods with very little code.

I strongly recommend reviewing this PR commit-by-commit.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen force-pushed the rpc_fe_new_connections branch from fb7f6ab to c0d2f41 Compare April 17, 2024 15:06
@seancolsen seancolsen marked this pull request as ready for review April 17, 2024 15:21
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Apr 17, 2024
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pavish pavish added this pull request to the merge queue Apr 30, 2024
Merged via the queue into develop with commit 7bacf30 Apr 30, 2024
35 checks passed
@pavish pavish deleted the rpc_fe_new_connections branch April 30, 2024 13:22
@kgodey kgodey added this to the v0.2.0-testing.1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants