Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3524, we added the following RPC APIs on the backend:
connections.add_from_known_connection
connections.add_from_scratch
This PR changes the front end to use those new RPC APIs.
In doing so, it also adds a new general-purpose utility, which I named
json-rpc-client-builder
. This code is Mathesar-agnostic, so I put it into a new place in our codebase — apackages
directory. See theREADME.md
files for more info.The Mathesar-specific code for these new API methods is is
src/api/rpc/
and you'll notice it's quite small. By following the pattern established here, we'll be able to implement the client side of new RPC methods with very little code.I strongly recommend reviewing this PR commit-by-commit.
Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin