Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect Z index for sheet header cells within table widget #3405

Closed
wants to merge 2 commits into from
Closed

Conversation

GopalVerma1303
Copy link

Fixes #3396

This pull request addresses issue #3396 by adjusting the z-index values for sheet components. The changes ensure proper layering, preventing the reported problem of incorrect z-index for sheet header cells within the table widget.

Technical details

Screenshots

Screenshot 2024-01-22 at 8 59 10 PM Screenshot 2024-01-22 at 8 59 24 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@GopalVerma1303
Copy link
Author

Hey @seancolsen! Please review.
Thanks!

@seancolsen seancolsen self-assigned this Jan 30, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jan 30, 2024
@seancolsen
Copy link
Contributor

I'm closing this because:

  1. After Fix active cell displaying above row header cell #3382 was merged, this PR now has enough merge conflicts that it probably makes sense to start over from scratch — both in terms of code changes and just conceptually, given the re-ordering I did to the z-index values in that PR.
  2. Further, the changes here don't seem to affect the right part of the app. I've added a comment in the issue which I hope will clarify where the issue is occurring.

@seancolsen seancolsen closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the table widget, column header cells should scroll underneath the origin cell
2 participants