-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
housekeeping #71
housekeeping #71
Conversation
This reverts commit 597fccc.
* specify dependency ranges I ended up trying to install mud on a computer with an older scikit-learn, and it ended up using the cache of like version 0.something, so I want to at least specify the major version we require for the more important libraries. * loosen matplotlib * 3.7 support is a pain... * typo * prevent warnings from numpy
3a51ca2
to
46febc3
Compare
46febc3
to
347ffaa
Compare
* print mypy and python versions in workflow * 'if save_path' used to fix 10 mypy errors * automatic fix using https://github.com/hauntsaninja/no_implicit_optional * post-fix linting * refactor to address C901: too complex * refactor to address C901: too complex * ignore C901 * fix typo * sort imports * if save_path is not None * no more 3.12 bc numpy 1.24 * fix all mypy issues with 1.8.0
so they take much longer bc of the thrown warnings, a whole minute extra. but loosening should pave the way to |
* experiment with 3.12 * loosen pandas for 3.12 * build updates * rename, try new build
works fine in 3.12 integration tests passing (even up to 3.12. tested on 3.9-3.12) |
mypy==1.8.0
updates (big jump! minor changes)black
apparently is linting notebooks by default now... so we're doing that, I guess.numpy >= 1.25
throws a lot of warnings right now, seemingly plotting-related. but tests do pass (just take longer). doesn't seem like much I can do about it for now.