fixes #1733 (ln_eq0)
#1744
Merged
fixes #1733 (ln_eq0)
#1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
added
the
enhancement ✨
t6s
reviewed
Nov 6, 2025
theories/exp.v
Outdated
| by rewrite -ler_expR expR0 lnK. | ||
| Qed. | ||
|
|
||
| Lemma ln_eq0 x : (ln x == 0) = (x <= 0) || (x == 1). |
There was a problem hiding this comment.
I am afraid of respecting the default value in an equality lemma like this.
Can we add 0< x as a hypothesis or add a warning to this lemma?
There was a problem hiding this comment.
The last commit does that, so I guess it is ok to merge now.
affeldt-aist
force-pushed
the
fixes_1733
branch
from
8031981 to
595ff9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1733
what about this fix?
@garrigue @gregweng
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers