Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Oct 30, 2025

Motivation for this change

This is a definition of the sequence of non-overlapping open intervals that covers an open interval of real numbers. It is used in particular to define contiguous intervals.

@IshiguroYoshihiro can you double-check?

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

Co-authored-by: IshiguroYoshihiro <[email protected]>
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Oct 30, 2025
@affeldt-aist
Copy link
Member Author

@IshiguroYoshihiro can you double-check?

ping

@t6s
Copy link
Member

t6s commented Nov 4, 2025

if I understand correctly, this PR is about the fact that open intervals form an open basis of the real line, but by quickly reading , I could not notice in the changes anything about basis. am I missing something?

@affeldt-aist
Copy link
Member Author

if I understand correctly, this PR is about the fact that open intervals form an open basis of the real line

this is just the proof that an open set can be covered by open intervals, nothing was attempted about basis

@t6s
Copy link
Member

t6s commented Nov 4, 2025

I have understood that this is not merely about the basis, but what matters here is the disjointness.

@affeldt-aist affeldt-aist requested a review from t6s November 4, 2025 06:05
@IshiguroYoshihiro
Copy link
Contributor

IshiguroYoshihiro commented Nov 4, 2025

@IshiguroYoshihiro can you double-check?

It looks good for me.

Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have quickly checked the statements, and they do not look bad.

@affeldt-aist
Copy link
Member Author

Thanks for the double-check!

@affeldt-aist affeldt-aist merged commit 2b30625 into math-comp:master Nov 5, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants