Skip to content

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Aug 13, 2025

Motivation for this change

fixes #1551

fixes #1558

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.13.0 milestone Aug 13, 2025
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Aug 13, 2025
@affeldt-aist affeldt-aist force-pushed the fix_1551 branch 2 times, most recently from 00c62b9 to 8f278a4 Compare August 14, 2025 02:05
@affeldt-aist
Copy link
Member Author

affeldt-aist commented Aug 14, 2025

@t6s the last commit fixes #1518

To summarize the naming fixes:

measurable_funPT  : measurable_fun [set: aT] f
measurable_funP   : measurable_fun D s
measurable_funPTI : measurable Y -> measurable (f @^-1` Y).
measurable_funP1  : measurable D -> measurable (D `&` f @^-1` [set y])

@affeldt-aist affeldt-aist requested a review from t6s August 14, 2025 02:07
@affeldt-aist
Copy link
Member Author

ping?

Copy link
Member

@hoheinzollern hoheinzollern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Wouldn't it make more sense to put the renamed lemmas into the "RENAMED" section of the changelog?

Feel free to ignore if you think it's inappropriate.

@affeldt-aist
Copy link
Member Author

The changes look good. Wouldn't it make more sense to put the renamed lemmas into the "RENAMED" section of the changelog?

Feel free to ignore if you think it's inappropriate.

I agree it's clearer.

@affeldt-aist affeldt-aist merged commit 84996a4 into math-comp:master Aug 16, 2025
65 of 66 checks passed
hoheinzollern pushed a commit to hoheinzollern/analysis that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renaming/refactoring 🔧 This is about a renaming or refactoring in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isMeasurableFun should live in measure.v

2 participants