Make cdf an instance of Cumulative (fix #1572)
#1686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The errors appear to be due to technical issues. Can I ignore them? |
Yosuke-Ito-345
changed the title
Cumulativecdf an instance of Cumulative (fix #1572)
They indeed look like elpi related, let us just ping @gares (who certainly already knows) |
|
Thank you for the review! |
2 tasks
This reverts commit 558558e. Reason: I mistakenly committed some unnecessary files.
affeldt-aist
force-pushed
the
generalize_cumulative
branch
from
3043ddc to
6661aa2
Compare
affeldt-aist
added
the
enhancement ✨
affeldt-aist
approved these changes
Aug 23, 2025
|
Thank you for the review and the merge. |
hoheinzollern
pushed a commit
to hoheinzollern/analysis
that referenced
this pull request
Sep 22, 2025
…p#1686) * generalize cumulative --------- Co-authored-by: Reynald Affeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1572
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers