Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpointed topologies with no backwards compatibility #1312

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Sep 7, 2024

Separates the Pointed structure from TopologicalType. Definitely not backwards compatible, but most people shouldn't notice since once we hit pseudometric_zmodType we put Pointed back in there anyway. See #1191 for a previous attempt.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@zstone1 zstone1 changed the title Draft: Unpointed topologies with no backwards compatability Unpointed topologies with no backwards compatability Sep 8, 2024
@zstone1
Copy link
Contributor Author

zstone1 commented Sep 8, 2024

Note this has some catastrophic performance regression in 8.18. From my little debugging, it appears the trivial tactic is slow when there are topologies/pointed topologies around. Sometimes adding a /= fixes it, so something pretty deep and bad is happening. I'm sure it's easy to fix with the right hint or instance, but I have no idea what that would be.

Performance is unaffected on 8.19 and 8.20, though. So it probably makes sense to wait if we're planning on dropping 8.18 support soon anyway.

Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop 8.18 asap and merge.

This was referenced Sep 12, 2024
@affeldt-aist affeldt-aist changed the title Unpointed topologies with no backwards compatability Unpointed topologies with no backwards compatibility Sep 13, 2024
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Sep 13, 2024
@affeldt-aist affeldt-aist added this to the 1.4.0 milestone Sep 13, 2024
@zstone1 zstone1 force-pushed the unpointed-no-backcompact branch from 100f779 to dc67866 Compare September 13, 2024 13:50
@zstone1 zstone1 merged commit a356624 into math-comp:master Sep 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants