Improved scroll performance

[mspensieri]

• Properly reuse tableview cells
• Extracted 3 subclasses from SOMessageCell - SOPhotoMessageCell, SOTextMessageCell, SOVideoMessageCell.

[VincentSit]

Looks like the image of play button can not customize?

[VincentSit]

More clearly than before, but why not use the class cluster design patterns? I think that should be better.

[mspensieri]

@VincentSit The play button was never customizable, I did not change this. I agree it would be a nice feature though :)

As for the class cluster pattern, I don't think it's appropriate in this case since the subclasses should not be transparent to the user. Each subclass has properties that the base class should not have (ex: the PhotoMessageCell has a 'mediaImageView' property. It doesn't make sense to expose this to the base class since it does not exist in the TextMessageCell class)

[VincentSit]

Thanks for the explanation.

[arturdev]

Thanks!

[matthewmoss]

After this commit, the table doesn't auto scroll when a message is sent or recieved. The improved scroll performance is awesome though

[matthewmoss]

Found the problem. All that was missing >= vs a >.

[mspensieri]

@matthewmoss Are you sure this is related to my changes? I haven't had any problems with scrolling after my commit

EDIT: I did some testing and it looks like this commit is actually the source of the issue : 6c7a977

[matthewmoss]

Oh, I am very sorry. I noticed the issue after that commit, but was told that this was because of yours. Since that time I found the problem. The first if statement needed to be >= rather than >, but thank you for getting back to me so quickly!

[mspensieri]

No worries :) you should open a pull request with that fix, and see if you can get my changes un-reverted !

[matthewmoss]

Defiantly will, the scroll enhancements are great and it will be a real shame if they are not included.

[arturdev]

Check #13
Your version has a bug, so I can't merge it yet.

[mspensieri]

@arturdev As pointed out above, the bug was actually introduced with this commit : 6c7a977

@matthewmoss seems to have found a fix for it, though

[matthewmoss]

@mspensieri Ok, issued a pull request. Hope your scrolling improvements will now be included.