Fixed type errors caused by commit having an irregular type
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusjunges
approved these changes
Apr 17, 2024
mateusjunges
changed the title
commit having an irregular type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed 'commit' in all places to be an int with a default of 1 so that type errors no longer occur.
CONTEXT:
I get this error when trying to consume messages using this command:
command: php vendor/bin/sail artisan kafka:consume --consumer=App\Commands\Consumers\Kafka\MyConsumer --topics=my_topic --groupId=my_group --maxMessage=5000 --maxTime=3600
error: Junges\Kafka\Config\Config::getCommit(): Return value must be of type int, string returned.
The value of commit is "1".