Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type errors caused by commit having an irregular type #276

Conversation

panaiteandreisilviu
Copy link
Contributor

@panaiteandreisilviu panaiteandreisilviu commented Apr 15, 2024

I changed 'commit' in all places to be an int with a default of 1 so that type errors no longer occur.

CONTEXT:

I get this error when trying to consume messages using this command:

command: php vendor/bin/sail artisan kafka:consume --consumer=App\Commands\Consumers\Kafka\MyConsumer --topics=my_topic --groupId=my_group --maxMessage=5000 --maxTime=3600

error: Junges\Kafka\Config\Config::getCommit(): Return value must be of type int, string returned.

The value of commit is "1".

@mateusjunges mateusjunges changed the title fixed type errors caused by 'commit' having an irregular type Fixed type errors caused by commit having an irregular type Apr 17, 2024
@mateusjunges mateusjunges merged commit 5164112 into mateusjunges:master Apr 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants