wip

docs/advanced-usage/9-sending-multiple-messages-with-the-same-producer.md

@@ -0,0 +1,19 @@
+---
+title: Sending multiple messages with the same producer
+weight: 9
+---
+
+Sometimes you may want to send multiple messages without having to create the consumer
+
+
+```php
+// In a service provider:
+
+\Junges\Kafka\Facades\Kafka::macro('myProducer', function () {
+    return $this->publish('broker')
+        ->onTopic('my-awesome-topic')
+        ->withConfigOption('key', 'value');
+});
+```
+
+Now, you can call `\Junges\Kafka\Facades\Kafka::myProducer()`, which will always apply the configs you defined in your service provider.

docs/producing-messages/5-publishing-to-kafka.md

@@ -16,4 +16,7 @@ $producer = Kafka::publish('broker')
     ->withHeaders(['header-key' => 'header-value']);
 
 $producer->send();
-```
+```
+
+If you want to send multiple messages, consider using the batch producer. The default `send` method is recommended for low-throughput systems only, as it 
+flushes the producer after every message that is sent.

docs/producing-messages/6-producing-message-batch-to-kafka.md

@@ -9,6 +9,9 @@ Then create as many messages as you want and push them to the `MesageBatch` inst
 Finally, create your producer and call the `sendBatch`, passing the `MessageBatch` instance as a parameter.
 This is helpful when you persist messages in storage before publishing (e.g. TransactionalOutbox Pattern).
 
+By using message batch, you can send multiple messages using the same producer instance, which is way faster than the default `send` method, which flushes the producer after each produced message.
+Messages are queued for asynchronous sending, and there is no guarantee that it will be sent immediately. The `sendBatch` is recommended for a system with high throughput.
+
 ```php
 use Junges\Kafka\Facades\Kafka;
 use Junges\Kafka\Producers\MessageBatch;

src/Config/Config.php

@@ -158,8 +158,6 @@ public function getProducerOptions(): array
             'compression.codec' => config('kafka.compression', 'snappy'),
             'bootstrap.servers' => $this->broker,
             'metadata.broker.list' => $this->broker,
-            'linger.ms' => 0,
-            'queue.buffering.max.ms' => 0
         ];
 
         return collect(array_merge($config, $this->customOptions, $this->getSaslOptions()))

src/Contracts/MessageProducer.php

@@ -2,8 +2,6 @@
 
 namespace Junges\Kafka\Contracts;
 
-use Junges\Kafka\Config\Sasl;
-use Junges\Kafka\Message\Message;
 use Junges\Kafka\Producers\MessageBatch;
 use Junges\Kafka\Producers\Producer;
 use Junges\Kafka\Support\Testing\Fakes\ProducerFake;

src/Contracts/Producer.php

@@ -19,7 +19,7 @@ public function produce(ProducerMessage $message, bool $shouldFlush = false): bo
      * @throws CouldNotPublishMessage
      * @throws \Junges\Kafka\Exceptions\CouldNotPublishMessageBatch
      */
-    public function produceBatch(MessageBatch $messageBatch, bool $shouldFlush = false): int;
+    public function produceBatch(MessageBatch $messageBatch): int;
 
     /**
      * @throws \Junges\Kafka\Exceptions\Transactions\TransactionShouldBeRetriedException
@@ -41,4 +41,7 @@ public function abortTransaction(int $timeoutInMilliseconds = 1000): void;
      * @throws \Junges\Kafka\Exceptions\Transactions\TransactionShouldBeAbortedException
      */
     public function commitTransaction(int $timeoutInMilliseconds = 1000): void;
+
+    /** Used to properly shut down the producer. */
+    public function flush(bool $shouldFlush = true): mixed;
 }

src/Producers/Builder.php

@@ -162,7 +162,7 @@ public function withDebugDisabled(): self
      *
      * @throws \Exception
      */
-    public function send(bool $shouldFlush = false): bool
+    public function send(bool $shouldFlush = true): bool
     {
         $producer = $this->build();
 

src/Producers/Producer.php

@@ -30,6 +30,8 @@ class Producer implements ProducerContract
     private readonly KafkaProducer $producer;
     private readonly Dispatcher $dispatcher;
 
+    private string $topic;
+
     public bool $transactionInitialized = false;
 
     public function __construct(
@@ -42,6 +44,13 @@ public function __construct(
         $this->dispatcher = App::make(Dispatcher::class);
     }
 
+    public function setTopic(string $topic): self
+    {
+        $this->topic = $topic;
+
+        return $this;
+    }
+
     /** Set the Kafka Configuration. */
     private function setConf(array $options): Conf
     {
@@ -63,7 +72,7 @@ public function produce(ProducerMessage $message, bool $shouldFlush = false): bo
     {
         $this->dispatcher->dispatch(new PublishingMessage($message));
 
-        $topic = $this->producer->newTopic($message->getTopicName());
+        $topic = $this->producer->newTopic($message->getTopicName() ?? $this->topic);
 
         $message = clone $message;
 
@@ -77,7 +86,7 @@ public function produce(ProducerMessage $message, bool $shouldFlush = false): bo
     }
 
     /** @inheritDoc */
-    public function produceBatch(MessageBatch $messageBatch, bool $shouldFlush = false): int
+    public function produceBatch(MessageBatch $messageBatch): int
     {
         if ($messageBatch->getTopicName() === '') {
             throw CouldNotPublishMessageBatch::invalidTopicName($messageBatch->getTopicName());
@@ -105,7 +114,7 @@ public function produceBatch(MessageBatch $messageBatch, bool $shouldFlush = fal
             $produced++;
         }
 
-        $this->flush($shouldFlush);
+        $this->flush();
 
         $this->dispatcher->dispatch(new MessageBatchPublished($messageBatch, $produced));
 
@@ -142,7 +151,7 @@ private function produceMessageBatch(ProducerTopic $topic, ProducerMessage $mess
      * @throws CouldNotPublishMessage
      * @throws \Exception
      */
-    private function flush(bool $shouldFlush = true): mixed
+    public function flush(bool $shouldFlush = true): mixed
     {
         // Here we define the flush callback that is called when flush is requested by
         // the developer or when the lottery wins. Flush is not needed in after all

src/Support/Testing/Fakes/ProducerBuilderFake.php

@@ -203,4 +203,9 @@ public function build(): ProducerFake
 
         return $this->makeProducer($conf);
     }
+
+    public function getProducer(): ProducerFake
+    {
+        return $this->build();
+    }
 }

src/Support/Testing/Fakes/ProducerFake.php

@@ -46,7 +46,7 @@ public function produce(ProducerMessage $message, bool $shouldFlush = false): bo
     }
 
     /** @throws \Junges\Kafka\Exceptions\CouldNotPublishMessageBatch */
-    public function produceBatch(MessageBatch $messageBatch, bool $shouldFlush = false): int
+    public function produceBatch(MessageBatch $messageBatch): int
     {
         if ($messageBatch->getTopicName() === '') {
             throw CouldNotPublishMessageBatch::invalidTopicName($messageBatch->getTopicName());