Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android plugin not working #22

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

kuhnroyal
Copy link
Contributor

@mateusfccp
Copy link
Owner

Are you serious that the reason was that the classes have the same name? This isn't documented anywhere!

update_available/example/pubspec.yaml Outdated Show resolved Hide resolved
update_available_android/pubspec.yaml Outdated Show resolved Hide resolved
@kuhnroyal
Copy link
Contributor Author

Are you serious that the reason was that the classes have the same name? This isn't documented anywhere!

Well for me that gave an error right away because it found 2 classes. Maybe you were also missing the implements: update_available - that was my problem first.

* fix naming collision of Dart plugin classes
* correctly register Android side
@kuhnroyal kuhnroyal force-pushed the fix-federated-packages branch from 073800a to 6a8e7b3 Compare February 9, 2023 14:37
@kuhnroyal
Copy link
Contributor Author

Fixed the line breaks.

@kuhnroyal
Copy link
Contributor Author

Are you serious that the reason was that the classes have the same name? This isn't documented anywhere!

I wonder what happens if some other package has a class with the same name 🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnimplementedError (UnimplementedError: getUpdateAvailability() has not been implemented.)
2 participants