Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required min SDK and add CI check #20

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

kuhnroyal
Copy link
Contributor

  • required due to meta: ^1.7.0 dependency
  • required due to invalid plugin registrations prior to Flutter 2.8.0

@mateusfccp
Copy link
Owner

@kuhnroyal
It seems meta: 1.7.0 requires Dart 2.12, which is available since Flutter 2.0.
https://github.com/dart-lang/sdk/blob/5b39eb2f0183fde63ae7d7851e8bfaf6a4075998/pkg/meta/pubspec.yaml

Thus, I'm failing to understanding the objective of this PR. Could you clarify?

@kuhnroyal
Copy link
Contributor Author

kuhnroyal commented Dec 25, 2022

Flutter versions prior 2.8.0 use an older meta version (1.3.0 I think). Since this package forces 1.7.0, you have to use min Flutter 2.8.0.
And also the way the plugins are registered was reworked in Flutter 2.8.0 and that way is already used.
You simply can not use this package with Flutter versions <2.8.0.

@mateusfccp mateusfccp added the infrastructure Related to infrastructure, like GitHub Actions label Dec 26, 2022
@mateusfccp
Copy link
Owner

Yeah, I didn't want to break this package for <3, but it seems it's already broken for <2.8. I will accept your PR and release a last 2 versions (2.2) with these changes. Then, release a new breaking for Flutter 3.

update_available/example/android/app/build.gradle Outdated Show resolved Hide resolved
update_available/example/android/app/build.gradle Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
* required due to `meta: ^1.7.0` dependency
* required due to invalid plugin registrations prior to Flutter 2.8.0
@mateusfccp mateusfccp merged commit a348990 into mateusfccp:master Jan 9, 2023
mateusfccp added a commit that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to infrastructure, like GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants