-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 👷 add doc builds to github actions #78
Conversation
It's worth noting I did refactor the docs so it's all generated in the docs folder, not just chucked into the root. I've tried my best to make sure this has no negative impacts but if anyone is aware of any issues, please do let me know. The action's currently failing for what seems to be an issue with the github bot account not having perms to push to this repo/org. |
oh yeah about sponsors and ads, feel free to remove them. 😃 also @DanielRuf mentions there's tracker code on the code. But I haven't find it yet. The tracker should be removed, or changed to the new account that we manage. |
Yea, there's google analytics too. I'll remove the ads, sponsors and tracking in this PR too. |
There's also the question of what to do with the showcase, paid themes and support us pages. Personally I say we just remove them |
I agree, feel free to remove them. About the support us page, that could be changed to contribute to this repository instead. (like helping with issues, create a good PR, etc.) |
Fully agree with you. Awesome! This is getting better and better :) |
Google analytics have also been removed. I have also updated a few things to point to the new repo etc
Still need @DanielRuf to allow the bot to push (ideally before merging) |
As they do not sponsor the new project, we can safely remove them. We do and did not receive any funding from them. |
Google Analytics? |
Not sure where / what needs to be done. |
I think that's about allowing github-actions bot to push the commits to the
on the second thought..., do we.... currently need Google Analytics? On the other hand, I do want to solve the |
We should make GitHub Pages available and probably link to the gh-pages branch. As @ChildishGiant said |
This could also be an issue where it just doesn't have permissions because it's a PR, that would make a lot of sense now I think of it. |
Ok, I've updated it. |
Right, secrets are not shared between forks and not available in PRs for good reasons. |
Awesome Guys! The url is now working 🥳 |
Once this is merged the docs will be updated. I think everything is ready now: LGTM |
What's stopping merge? |
Updated it to https://materializecss.github.io/materialize/ right now. |
You may update the "-- Browse the docs --" link in README.md accordingly. |
Added to #90 |
Proposed changes
Added a workflow to compile and deploy the docs (Closes #71). For this example it's publishing to https://childishgiant.github.io/materialize Some of the links don't work as it goes to https://childishgiant.github.io but this won't be an issue if we set up a custom domain (one line change). This could also be fixed if we decide to stick with https://materializecss.github.io/materialize
I think there's an important question of what we do with parts of the docs such as the patreon sponsors and ads.
This is probably a licensing (and moral) issue so I'd greatly appreciate any thoughts on this
Checklist: