Only animate CGSize and CGPoint key paths additively if additive is enabled. #72
Conversation
…nabled. Prior to this change, CGSize and CGPoint animations were being animated additively even if the additive property was disabled. Added tests to catch regressions in the future.
|
|
||
| timing = MotionTiming(delay: 0, | ||
| duration: 1, | ||
| curve: MotionCurveMakeBezier(p1x: 0, p1y: 0, p2x: 0, p2y: 0), |
There was a problem hiding this comment.
I'm probably misunderstanding timing curves, but doesn't this timing curve mean "never go to the 'to' value"? If all control points are zero?
There was a problem hiding this comment.
There are four control points in a cubic bezier, p0 and p3 represent the anchor points — respectively anchored at 0, 0, and 1,1 — and p1 and p2 are the control points. This API accepts p1 and p2.
While this particular cubic bezier is odd, it's not particularly important for the purposes of this test.
| XCTAssertTrue(animation.isAdditive, "Animation is not additive when it should be.") | ||
| } | ||
|
|
||
| func testPositionKeyPathsAnimateAdditively() { |
There was a problem hiding this comment.
Nit/naming: test__Point__KeyPathsAnimateAdditively
|
|
||
| XCTAssertTrue(animation.isAdditive, "Animation is not additive when it should be.") | ||
| } | ||
| } |
There was a problem hiding this comment.
Are CGRect not additive no matter what?
There was a problem hiding this comment.
Currently no. CGRect support isn't currently implemented.
Prior to this change, CGSize and CGPoint animations were being animated additively even if the additive property was disabled.
Added tests to catch regressions in the future.