fix(ripple): multiple touches causing ripples to start from center #5367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/596047639
branch
2 times, most recently
from
060633e to
cb658b4
Compare
copybara-service
bot
force-pushed
the
cl/596047639
branch
from
cb658b4 to
34115f6
Compare
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the `pointerId` changes with each touch. Fixes #5349 PiperOrigin-RevId: 596668539
copybara-service
bot
force-pushed
the
cl/596047639
branch
from
34115f6 to
cef1b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ripple): multiple touches causing ripples to start from center
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the
pointerIdchanges with each touch.Fixes #5349