Fix ripple directive for lit-html 0.13#164
Merged
straversi merged 1 commit intomaterial-components:masterfrom Jan 8, 2019
Merged
Fix ripple directive for lit-html 0.13#164straversi merged 1 commit intomaterial-components:masterfrom
straversi merged 1 commit intomaterial-components:masterfrom
Conversation
This was referenced Nov 18, 2018
Closed
straversi
approved these changes
Jan 8, 2019
Contributor
straversi
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 144213a packages got dependencies updated for lit-html 0.13. However, there was a breaking change in lit-html 0.13 that was not taken into account:
This PR will update the Ripple directive to use the new format.
CC @azakus