Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-dialog: text is not selectable. #5145

Closed
vdegenne opened this issue Nov 1, 2023 · 1 comment · Fixed by #5347
Closed

md-dialog: text is not selectable. #5145

vdegenne opened this issue Nov 1, 2023 · 1 comment · Fixed by #5347
Assignees

Comments

@vdegenne
Copy link
Contributor

vdegenne commented Nov 1, 2023

What is affected?

Component

Description

Text can't be selected in any part of the <md-dialog> element (headline, content, actions), the problem was detected in Chrome specifically (118.0). In Firefox the text can be selected.

note: Following this MDN link https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog text can be selected in the same browser that the issue was reported from.

note 2: text can be selected in inputs.

Reproduction

https://lit.dev/playground/#gist=7e36ba007a4539650ff127804750d97b

Workaround

No workaround found at the time of this report.

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

@material/web v1.0.0

Browser/OS/Node environment

Browser: Chrome 118.0.5993.117

@vdegenne
Copy link
Contributor Author

vdegenne commented Nov 1, 2023

The problem appears to be Chrome specific to dialogs : https://bugs.chromium.org/p/chromium/issues/detail?id=1498660

@asyncLiz asyncLiz self-assigned this Dec 26, 2023
copybara-service bot pushed a commit that referenced this issue Dec 27, 2023
Fixes #5145

Added some notes on Material dialog focusing. Normally the dialog should *not* be focused, so you may wonder why we care about delegating focus at all. It's because:

1. We don't have focus trapping yet
2. We need to handle what happens when there isn't a focusable child in the dialog, even though that's against spec.

PiperOrigin-RevId: 593872475
copybara-service bot pushed a commit that referenced this issue Dec 27, 2023
Fixes #5145

Added some notes on Material dialog focusing. Normally the dialog should *not* be focused, so you may wonder why we care about delegating focus at all. It's because:

1. We don't have focus trapping yet
2. We need to handle what happens when there isn't a focusable child in the dialog, even though that's against spec.

PiperOrigin-RevId: 593872475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants