Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[md-radio] 1.0.0-pre.9 breaks radio behavior in radio groups #4347

Closed
christophe-g opened this issue May 26, 2023 · 4 comments · Fixed by #4335
Closed

[md-radio] 1.0.0-pre.9 breaks radio behavior in radio groups #4347

christophe-g opened this issue May 26, 2023 · 4 comments · Fixed by #4335
Assignees

Comments

@christophe-g
Copy link
Contributor

christophe-g commented May 26, 2023

Thanks a lot for the new release - it starts to look really good.

1.0.0-pre.9 seems to break (SingleSelectionController) md-radio as illustrated below:

  • radio are not selected on click
  • navigation through radio with keyboard arrows do not select the active radio

non working example (1.0.0-pre.9)
vokoscreenNG-2023-05-26_15-37-40

working example (1.0.0-pre.8)
replace pre.9 by pre.8 in playground

link to playground

@asyncLiz asyncLiz self-assigned this May 26, 2023
@asyncLiz
Copy link
Collaborator

rip 🙃

@christophe-g
Copy link
Contributor Author

rip upside_down_face

Oh yeah sorry, two animations in the same issue is a bit too much.

@austinw-fineart
Copy link

austinw-fineart commented May 31, 2023

To be more technical, the radios still function logic-wise. It's just that the styling relied on the existence of the checked attribute that is no longer reflected by the corresponding property.

@asyncLiz
Copy link
Collaborator

Yup! I've got a PR coming to fix the styling soon, just gotta investigate a client failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants