Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

Closed
kfranqueiro opened this issue Feb 1, 2019 · 0 comments
Closed

Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

kfranqueiro opened this issue Feb 1, 2019 · 0 comments
Milestone
March release (1....

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Feb 1, 2019 •
edited
Loading

We added an mdc-dom package with a common matches function, but we still have 2 packages using their own version: Ripple and Tab Scroller.

Additionally, these packages use a version which is run eagerly ahead-of-time, which poses problems in SSR scenarios. (See material-components/material-components-web-react#654)

Edit: Only Ripple actually runs the function eagerly, although both work in the same manner.

We should update these components to use mdc-dom and remove the duplicate functions.
@abhiomkar abhiomkar added this to the 0.45.0 milestone Feb 4, 2019
@julien1619 julien1619 mentioned this issue Feb 7, 2019
Merged
@kfranqueiro kfranqueiro mentioned this issue Feb 11, 2019
Merged
acdvorak pushed a commit that referenced this issue Feb 14, 2019
@julien1619 @acdvorak
fix(ripple): Use mdc-dom.matches everywhere (#4372)
55e4229 
Fixes #4340

`mdc-dom` implements a `matches()` method that wasn't used everywhere. These custom implementations prevented some SSR usage of the material-components library. This commit removes all the custom implementations.

I removed some tests that were testing a now removed method, and I handled to make the other pass.

PS: This is my first contribution here, I hope I did everything right!

BREAKING CHANGE: `getMatchesProperty()` has been removed from `@material/ripple/util`. Use `matches()` from `@material/dom/ponyfill` instead.
acdvorak pushed a commit that referenced this issue Feb 14, 2019
@julien1619 @acdvorak
fix(ripple): Use mdc-dom.matches everywhere (#4372)
a2aa3c8 
Fixes #4340

`mdc-dom` implements a `matches()` method that wasn't used everywhere. These custom implementations prevented some SSR usage of the material-components library. This commit removes all the custom implementations.

I removed some tests that were testing a now removed method, and I handled to make the other pass.

PS: This is my first contribution here, I hope I did everything right!

BREAKING CHANGE: `getMatchesProperty()` has been removed from `@material/ripple/util` and `@material/tab-scroller/util`. Use `matches()` from `@material/dom/ponyfill` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March release (1.0.0)
Development

No branches or pull requests
2 participants
@abhiomkar @kfranqueiro