Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme 0.1.6 CSS custom properties not compatible with sass 3.5 #1075

Closed
grzuy opened this issue Aug 4, 2017 · 0 comments
Closed

theme 0.1.6 CSS custom properties not compatible with sass 3.5 #1075

grzuy opened this issue Aug 4, 2017 · 0 comments
Assignees

Comments

@grzuy
Copy link
Contributor

grzuy commented Aug 4, 2017

What MDC-Web Version are you using?

mdc-theme 0.1.6

What are the steps to reproduce the bug?

Use sass (ruby sass) latest release (3.5) to compile mdc-theme.scss

$ gem install sass -v 3.5
Successfully installed sass-3.5.0
$ sass _3.5_ packages/mdc-theme/mdc-theme.scss

What is the expected behavior?

That it outputs normally theme CSS custom properties, i.e.

$ sass _3.5_ packages/mdc-theme/mdc-theme.scss | grep "\--mdc-theme-primary:"
  --mdc-theme-primary: #3f51b5;

What is the actual behavior?

Leaves theme CSS custom properties unprocessed

$ sass _3.5_ packages/mdc-theme/mdc-theme.scss | grep "\--mdc-theme-primary:"
  --mdc-theme-primary: map-get($mdc-theme-property-values, $style);

Any other information you believe would be useful?

The reason why this issue isn't affecting MDC demos yet is because node-sass (via libsass) is still in the process of catching up with latest changes in sass-spec.

But it seems that libsass will soon release 3.5 with the same behavior for CSS custom properties. See sass/libsass#2076.

Once the issue linked above is addressed, libsass released and node-sass updated, the demos will suffer from the same issue and the theme properties won't be processed.

@grzuy grzuy changed the title theme 0.1.6 doesn't process custom properties with sass 3.5 theme 0.1.6 CSS custom properties not compatible with sass 3.5 Aug 4, 2017
@acdvorak acdvorak self-assigned this Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants