Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Update backdrop.md #25

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

velociberry
Copy link

Line 12. It's unclear what the answer is intended to do. Is it discouraging use in Flutter? When it says you can achieve the result with "existing components and classes" does that mean it's recommending using something other than the backdrop component, or that you can hack the backdrop in a way that's ... something? Unclear what the 3rd sentence means, basically.

Line 16. When you say "a view" do you literally mean the Android definition of a view? https://developer.android.com/reference/android/view/View

Line 16. Does "reveal information behind it" mean reveal the back layer? Or something else?

Line 19. "You will have a separate widget to build out the front layer" Is this "separate widget" referring to the stateful widget or something else? If something else, what is that else?

Line 36. By "secondary" do you mean not dominant in the sense you need to take an action to access it?

Line 36. How is the back layer "persistent"? It's always there, but not always open (and I think often the spec uses persistent to mean active/open/inyourface.

Line 42. Does this mean a single front or back layer, as in not both? Or does it mean both, but is unique in some other way? Unclear on phrasing.

Line 42. "containing the backdrop to a vertical back and forth interaction" what does this mean?

Thanks for starting a pull request on Material Components!

Don't forget:

  • Are you sure you mean this repo? This repository is a reference to the main Flutter repository. Code-level issues should be created there.
  • Link to GitHub issues it solves. closes #1234
  • Sign the CLA bot. You can do this once the pull request is opened.

Be sure to read the Flutter guide on contributing.

Related issues

  • Type # and the issue number or # and select the from the inline drop down.

Line 12. It's unclear what the answer is intended to do. Is it discouraging use in Flutter? When it says you can achieve the result with "existing components and classes" does that mean it's recommending using something other than the backdrop component, or that you can hack the backdrop in a way that's ... something? Unclear what the 3rd sentence means, basically.

Line 16. When you say "a view" do you literally mean the Android definition of a view? https://developer.android.com/reference/android/view/View

Line 16. Does "reveal information behind it" mean reveal the back layer? Or something else? 

Line 19. "You will have a separate widget to build out the front layer" Is this "separate widget" referring to the stateful widget or something else? If something else, what is that else? 

Line 36. By "secondary" do you mean not dominant in the sense you need to take an action to access it?

Line 36. How is the back layer "persistent"? It's always there, but not always open (and I think often the spec uses persistent to mean active/open/inyourface.

Line 42. Does this mean a single front or back layer, as in not both? Or does it mean both, but is unique in some other way? Unclear on phrasing.

Line 42. "containing the backdrop to a vertical back and forth interaction" what does this mean?
@willlarche
Copy link
Contributor

willlarche commented Dec 13, 2018

Line 12 was meant to help someone wondering if there was a dedicated Backdrop class (widget). There isn't one. And we don't intend to make one because it's not a good candidate for one. What you should do instead is use existing classes / widgets to make a backdrop bespoke to your app.

docs/components/backdrop.md Outdated Show resolved Hide resolved
docs/components/backdrop.md Show resolved Hide resolved
docs/components/backdrop.md Outdated Show resolved Hide resolved
@willlarche
Copy link
Contributor

Line 16, yes I meant reveal the back layer.

@willlarche
Copy link
Contributor

For line 16, I kinda mean that kind of view. I don't have a good all purpose word for a discrete area of the UI. So I use 'view'.

@willlarche
Copy link
Contributor

Line 19, it could be a stateful widget or a stateless widget. Depends on the needs of the customer. Almost any widget could be expected here.

@willlarche
Copy link
Contributor

Line 36, yes that kind of secondary. Also, not some place you'd expect the user to hang out. They may spend an hour on the feed in the front layer, but filtering it with the back layer is a quick interaction.


_The appearance of the backdrop can change with context._
* Some apps may only need a single front layer and back layer, containing the backdrop to a vertical back and forth interaction.
* Some apps only need a single front layer and back layer, containing the backdrop to a vertical back and forth interaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I didn't write this well. The front layer's content could change considerably depending on what a user does in the back layer to affect it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which line does this comment refer to?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found it

Copy link
Author

@velociberry velociberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line 11, "Is there a widget for backdrop" -- the next line says "In Flutter, the backdrop is an advanced component." Are a widget and a component the same thing? At first I thought they weren't, but now I'm wondering if they are synonymous.

@velociberry
Copy link
Author

velociberry commented Dec 14, 2018

For line 16, I kinda mean that kind of view. I don't have a good all purpose word for a discrete area of the UI. So I use 'view'.

I ask because the spec was using "view" incorrectly for years, and I think we landed on "scrollable area." I think in this instance you mean "surface."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants