[MaterialSwitch] Fix drawable scaling for API < 23 #3513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsn5ft
reviewed
Aug 9, 2023
| @@ -293,8 +293,7 @@ public static Drawable compositeTwoLayeredDrawable( | |||
| drawable.setLayerGravity(1, Gravity.CENTER); | |||
| } else { | |||
| Drawable scaledTopLayerDrawable = | |||
| new ScaledDrawableWrapper(topLayerDrawable, topLayerNewWidth, topLayerNewHeight) | |||
| .getDrawable(); | |||
| new ScaledDrawableWrapper(topLayerDrawable, topLayerNewWidth, topLayerNewHeight); | |||
There was a problem hiding this comment.
Thanks @pubiqq! Can you provide some more information:
- More description of the issue pre API level 23
- Before and After screenshots
- Explanation around why removing the
.getDrawable()fixes it
There was a problem hiding this comment.
This code is incorrect because a wrapped drawable (topLayerDrawable) is used instead of a wrapper (scaled topLayerDrawable).
We're using ScaledDrawableWrapper here to get a scaled topLayerDrawable on pre-23 API (on API 23 and above we are using built-in LayerDrawable.setLayerSize() for this).
leticiarossi
approved these changes
Sep 6, 2023
leticiarossi
added
the
Reviewing Internally
leticiarossi
removed
the
Reviewing Internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.