Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time picker] Presumably wrong time input field separator size #4160

Open
Gustl22 opened this issue May 5, 2024 · 0 comments
Open

[Time picker] Presumably wrong time input field separator size #4160

Gustl22 opened this issue May 5, 2024 · 0 comments

Comments

@Gustl22
Copy link

Gustl22 commented May 5, 2024

Description: Full description of issue here

The separator of the time input for the time picker is slightly too big. This results in a non centered oversized colon. For comparison in time picker specs:

Time picker:

  • Time picker time selector label text size: 57
  • Time picker time selector separator size: 57

Time input:

  • Time input time input field label text size: 45
  • Time input time input field separator size: 57 but should be 45 (see number 2 in image)
unnamed

Expected behavior: Screenshots and/or description of expected behavior
The colon / separator should have the same font size as the label text, so that it is shown vertically centered.

Source code:

<macro name="m3_comp_time_picker_time_selector_label_text_type">?attr/textAppearanceDisplayLarge</macro>
<macro name="m3_comp_time_picker_period_selector_selected_label_text_color">?attr/colorOnTertiaryContainer</macro>
<macro name="m3_comp_time_picker_period_selector_unselected_label_text_color">?attr/colorOnSurfaceVariant</macro>
<macro name="m3_comp_time_picker_period_selector_label_text_type">?attr/textAppearanceTitleMedium</macro>
<!-- Group: Enabled - Headline -->
<macro name="m3_comp_time_picker_headline_color">?attr/colorOnSurfaceVariant</macro>
<macro name="m3_comp_time_picker_headline_type">?attr/textAppearanceLabelMedium</macro>
<!-- Group: Enabled - Separator -->
<macro name="m3_comp_time_picker_time_selector_separator_color">?attr/colorOnSurface</macro>
<macro name="m3_comp_time_picker_time_selector_separator_type">?attr/textAppearanceDisplayLarge</macro>

<style name="Widget.Material3.MaterialTimePicker.Button" parent="Widget.MaterialComponents.TimePicker.Button">

<item name="materialDisplayDividerStyle">@style/Widget.Material3.MaterialTimePicker.Display.Divider</item>
<item name="materialButtonOutlinedStyle">@style/Widget.Material3.MaterialTimePicker.Button</item>

There should be a value for @style/Widget.Material3.MaterialTimePicker.Button.Divider.

Minimal sample app repro: Every sample of time picker will do it.

Android API version: This concerns the Material Spec and not Android specifically.

Material Library version: 1.12.0

Device: Every

To help us triage faster, please check to make sure you are using the latest version of the library.

We also happily accept pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants