Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time Picker ] Chip background color not changing when switch to INPUT_MODE_KEYBOARD #3454

Open
bineeshr opened this issue Jun 22, 2023 · 0 comments · May be fixed by #4005
Open

[Time Picker ] Chip background color not changing when switch to INPUT_MODE_KEYBOARD #3454

bineeshr opened this issue Jun 22, 2023 · 0 comments · May be fixed by #4005

Comments

@bineeshr
Copy link

bineeshr commented Jun 22, 2023

Description: Full description of the issue here

Chip background color working in INPUT_MODE_CLOCK

Screenshot_20230620-131601 (1)

When I switch to INPUT_MODE_KEYBOARD the Chip background color not working

Screenshot_20230622-113052

Source code:

<style name="TimePickerTheme" parent="@style/ThemeOverlay.Material3.MaterialTimePicker">
    <item name="chipStyle">@style/TimePickerTheme.Chip</item>
    <item name="colorSurface">@color/colorSurface</item>
    <item name="android:colorPrimary">@color/color_orange_100</item>
    <item name="materialClockStyle">@style/TimePickerTheme.Clock</item>
    <item name="borderlessButtonStyle">@style/TimePickerTheme.BorderlessButtonStyle</item>
    <item name="materialButtonOutlinedStyle">@style/TimePickerTheme.BorderOutlineStyle</item>
    <item name="materialTimePickerTitleStyle">@style/headline_4</item>
</style>


<style name="TimePickerTheme.Clock" parent="Widget.Material3.MaterialTimePicker.Clock">
    <item name="clockHandColor">@color/color_orange_100</item>
    <item name="clockFaceBackgroundColor">@color/time_picker_clock_color</item>
    <item name="clockNumberTextColor">@color/colorOnSurface</item>
</style>

<style name="TimePickerTheme.Chip" parent="Widget.Material3.MaterialTimePicker.Display">
    <item name="chipBackgroundColor">@color/time_picker_chip_selector</item>
    <item name="android:textAppearance">@style/hds</item>
    <item name="android:textColor">@color/colorOnSurface</item>
</style>

<style name="TimePickerTheme.BorderlessButtonStyle" parent="Widget.Material3.Button.TextButton">
    <item name="android:textColor">@color//color_orange_100</item>
    <item name="android:textAppearance">@style/button.large</item>
    <item name="strokeWidth">0dp</item>
</style>

<style name="TimePickerTheme.BorderOutlineStyle" parent="Widget.Material3.MaterialTimePicker.Button">
    <item name="android:textColor">@color/colorOnPrimary</item>
    <item name="android:textAppearance">@style/headline_6</item>
    <item name="android:backgroundTint">@color/time_picker_border_button_selector</item>
</style>

Minimal sample app repro: Please consider attaching a minimal sample app that reproduces the issue. This will help narrow down the conditions required for reproducing the issue, and it will speed up the bug fix process. You may attach a zip file of the sample app or link to a GitHub repo that contains the sample app.

Android API version: Android 13

Material Library version: 1.8.0

Device: Checked on Pixel 4

To help us triage faster, please check to make sure you are using the latest version of the library.

We also happily accept pull requests.

@bineeshr bineeshr added the bug label Jun 22, 2023
@bineeshr bineeshr changed the title [Time Picker ] Chip background color not changing when I switch to INPUT_MODE_KEYBOARD [Time Picker ] Chip background color not changing when switch to INPUT_MODE_KEYBOARD Jun 22, 2023
@paulfthomas paulfthomas self-assigned this Jun 22, 2023
@manabu-nakamura manabu-nakamura linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants