Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow backward compatibility with gcc 4.8 #61

Merged
merged 2 commits into from
Dec 6, 2022
Merged

allow backward compatibility with gcc 4.8 #61

merged 2 commits into from
Dec 6, 2022

Conversation

ferdymercury
Copy link
Collaborator

Fixes #56
Fixes #59

@ferdymercury
Copy link
Collaborator Author

ferdymercury commented Dec 3, 2022 •
edited
Loading

@behrisch @jmakov can you test if this solves your issue without having to comment the open function?

@behrisch
Copy link
Contributor

behrisch commented Dec 4, 2022

Looks good to me, the updated build results will show up tomorrow here: https://build.opensuse.org/package/show/science:dlr/sumo_nightly

@ferdymercury
Copy link
Collaborator Author

Do the nightlies work? shall I merge?

@behrisch
Copy link
Contributor

behrisch commented Dec 6, 2022 •
edited
Loading

yes, please. And thanks for fixing!

@ferdymercury ferdymercury merged commit 755da78 into master Dec 6, 2022
@ferdymercury ferdymercury deleted the gcc4_8 branch December 6, 2022 09:31
@svigerske svigerske mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

call to implicitly-deleted copy constructor of 'zstr::ifstream' Incompatible with GCC 4.8.2
2 participants
@ferdymercury @behrisch