perf: Streamlining scans and messaging; Debugging info

package.json

@@ -34,6 +34,7 @@
     ]
   },
   "devDependencies": {
+    "@rollup/plugin-strip": "^2.0.1",
     "addons-linter": "^3.7.0",
     "archiver-promise": "~1.0",
     "ava": "^3.15.0",

scripts/build.js

@@ -13,6 +13,7 @@ const { minify } = require('terser')
 const replace = require('replace-in-file')
 const rollup = require('rollup')
 const sharp = require('sharp')
+const strip = require('@rollup/plugin-strip')
 const terser = require('rollup-plugin-terser').terser
 
 
@@ -324,7 +325,13 @@ async function bundleCode(browser, debug) {
 
 			bundleOption.input = {
 				input: ioPair.mainSourceFile,
-				plugins: [terser(makeTerserOptions(defines)), esformatter()]
+				plugins: debug
+					? [ terser(makeTerserOptions(defines)), esformatter() ]
+					: [
+						strip({ functions: ['debugSend', 'debugLog'] }),
+						terser(makeTerserOptions(defines)),
+						esformatter()
+					]
 			}
 
 			bundleOption.output = {

scripts/compare.sh

@@ -17,8 +17,9 @@ echo "    <browser> <browser> d"
 echo "    <browser> d"
 echo
 echo "You may want to run the following first"
-echo "    node scripts/build.js --browser all --debug"
-echo "    node scripts/build.js --browser all"
+echo "    node scripts/build.js [--skip-linting] --skip-zipping --browser all --debug"
+echo "    node scripts/build.js [--skip-linting] --skip-zipping --browser all"
+echo
 
 if [ ! "$1" ] || [ ! "$2" ]; then
 	echo "Missing first or second arg"

src/assemble/_landmarksFinder.js

@@ -105,6 +105,8 @@ export default function LandmarksFinder(win, doc) {
 	let currentlySelectedElement
 
 	function updateSelectedIndexAndReturnElementInfo(index) {
+		// TODO: Don't need an index check, as we trust the source. Does that
+		//       mean we also don't need the length check?
 		if (landmarks.length === 0) return
 		currentlySelectedIndex = index
 		currentlySelectedElement = landmarks[index].element
@@ -113,7 +115,7 @@ export default function LandmarksFinder(win, doc) {
 			role: landmarks[index].role,
 			roleDescription: landmarks[index].roleDescription,
 			label: landmarks[index].label
-			// No need to send the selector this time
+			// No need to send the selector or warnings
 		}
 	}
 
@@ -189,6 +191,10 @@ export default function LandmarksFinder(win, doc) {
 			parentLandmark = element
 		}
 
+		// One just one page I've seen an error here in Chrome (91) which seems
+		// to be a bug, because only one HTMLElement was returned; not an
+		// HTMLCollection. Checking for this would cause a slowdown, so
+		// ignoring for now.
 		for (const elementChild of element.children) {
 			getLandmarks(elementChild, depth, parentLandmark)
 		}

src/assemble/gui.html

@@ -99,38 +99,49 @@
 					</details>
 				</dd>
 
-				<dt id="statsScansTerm" data-message="statsScansTerm"></dt></dt>
-			<dd>
-				<span id="scans">0</span>
-				<details class="tooltip">
-					<summary class="definition" aria-labelledby="define-statsScansTerm statsScansTerm">
-						<span id="define-statsScansTerm" data-message="statsDefine" class="visually-hidden"></span>
-					</summary>
-					<p data-message="statsScansDefinition"></p>
-				</details>
-			</dd>
+				<dt id="statsMutationScansTerm" data-message="statsMutationScansTerm"></dt>
+				<dd>
+					<span id="mutationScans">0</span>
+					<details class="tooltip">
+						<summary class="definition" aria-labelledby="define-statsMutationScansTerm statsMutationScansTerm">
+							<span id="define-statsMutationScansTerm" data-message="statsDefine" class="visually-hidden"></span>
+						</summary>
+						<p data-message="statsMutationScansDefinition"></p>
+					</details>
+				</dd>
 
-			<dt id="statsPauseTerm" data-message="statsPauseTerm"></dt>
-			<dd>
-				<span id="pause">&mdash;</span>ms
-				<details class="tooltip">
-					<summary class="definition" aria-labelledby="define-statsPauseTerm statsPauseTerm">
-						<span id="define-statsPauseTerm" data-message="statsDefine" class="visually-hidden"></span>
-					</summary>
-					<p data-message="statsPauseDefinition"></p>
-				</details>
-			</dd>
+				<dt id="statsNonMutationScansTerm" data-message="statsNonMutationScansTerm"></dt>
+				<dd>
+					<span id="nonMutationScans">0</span>
+					<details class="tooltip">
+						<summary class="definition" aria-labelledby="define-statsNonMutationScansTerm statsNonMutationScansTerm">
+							<span id="define-statsNonMutationScansTerm" data-message="statsDefine" class="visually-hidden"></span>
+						</summary>
+						<p data-message="statsNonMutationScansDefinition"></p>
+					</details>
+				</dd>
 
-			<dt id="statsDurationTerm" data-message="statsDurationTerm"></dt>
-			<dd>
-				<span id="duration">&mdash;</span>ms
-				<details class="tooltip">
-					<summary class="definition" aria-labelledby="define-statsDurationTerm statsDurationTerm">
-						<span id="define-statsDurationTerm" data-message="statsDefine" class="visually-hidden"></span>
-					</summary>
-					<p data-message="statsDurationDefinition"></p>
-				</details>
-			</dd>
+				<dt id="statsPauseTerm" data-message="statsPauseTerm"></dt>
+				<dd>
+					<span id="pause">&mdash;</span>ms
+					<details class="tooltip">
+						<summary class="definition" aria-labelledby="define-statsPauseTerm statsPauseTerm">
+							<span id="define-statsPauseTerm" data-message="statsDefine" class="visually-hidden"></span>
+						</summary>
+						<p data-message="statsPauseDefinition"></p>
+					</details>
+				</dd>
+
+				<dt id="statsDurationTerm" data-message="statsDurationTerm"></dt>
+				<dd>
+					<span id="duration">&mdash;</span>ms
+					<details class="tooltip">
+						<summary class="definition" aria-labelledby="define-statsDurationTerm statsDurationTerm">
+							<span id="define-statsDurationTerm" data-message="statsDefine" class="visually-hidden"></span>
+						</summary>
+						<p data-message="statsDurationDefinition"></p>
+					</details>
+				</dd>
 			</dl>
 			<p data-message="statsInfo"></p>
 		</details>

src/assemble/messages.common.en_GB.json

@@ -247,23 +247,31 @@
   },
 
   "statsCheckedMutationsDefinition": {
-    "message": "Mutations that Landmarks has tested to see if they are relevant."
+    "message": "Mutations that Landmarks has tested to see if they are relevant (mutations that happen during a pause in scanning are ignored)."
   },
 
-  "statsScansTerm": {
-    "message": "Scans:"
+  "statsMutationScansTerm": {
+    "message": "Mutation scans:"
   },
 
-  "statsScansDefinition": {
-    "message": "Number of times the page has been scanned for landmarks."
+  "statsMutationScansDefinition": {
+    "message": "Number of times the page has been scanned for landmarks due to mutations. Includes scans triggered directly by mutations, as well as scans scheduled for after a pause brought on by multiple successive mutations."
+  },
+
+  "statsNonMutationScansTerm": {
+    "message": "Non-mutation scans:"
+  },
+
+  "statsNonMutationScansDefinition": {
+    "message": "Number of times the page has been scanned for landmarks for other reasons, such as: page load; use of History API; user command whilst scanning is paused due to prior mutations."
   },
 
   "statsPauseTerm": {
     "message": "Pause time:"
   },
 
   "statsPauseDefinition": {
-    "message": "Time during which subsequent changes to the page will be ignored."
+    "message": "Time window during which subsequent changes to the page will be ignored."
   },
 
   "statsDurationTerm": {