test: Use the ES modules directly #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need for the generated CJS files and use of rollup in testing. Thanks to https://remysharp.com/2019/08/16/build-free-code-and-testing-es-module-imports and avajs/ava#2417 (comment) :-).
matatk
commented
Jul 28, 2020
package.json
Outdated
| @@ -23,12 +23,15 @@ | |||
| "pre-commit": "npm run build:all" | |||
| } | |||
| }, | |||
| "esm": { "cjs": true }, | |||
|
Need to remove redundant files from |
matatk
added a commit
that referenced
this pull request
Jan 30, 2021
* Use rollup to make a version of the LandmarksFinder code that can be run via puppeteer (this had been unintentionally broken by #385). * Rollup is only run if the source has changed since last time. * Make the build script clearer when building a debug (as opposed to test) build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need for the generated CJS files and use of rollup in testing.
Thanks to https://remysharp.com/2019/08/16/build-free-code-and-testing-es-module-imports and avajs/ava#2417 (comment) :-).