JSON-to-HTML and HTML-to-JSON #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make a directory structure that will be compatible with adding more fixture-and-expectation tests. * Code the variable names in test-landmarks.js in line with fixture and expectation terminology. * Streamline the structure of the expectations (no more "expected" key).
* Create JsonToHtml and run an initial test. * Include the name of the thing being tested in all test scripts' fundamental "is it working?" tests.
The single test is still pretty simple, but covers both of the previous ones, which were really just to get started.
* This is written as a Node module and will eventually be run-able as a CLI script. * The current test only checks for elements and contained text; need to add attributes. * Also rename variable in LandmarksFinder test to make more sense.
Three of the test runners are very similar; this harmonises the bits that can be harmonised. In future it would be nice to DRY these.
The code is very common between the script and the test runner, which obviates the need to do a bit of refactoring. That will have the advantage of removing the JSDOM dependency from the test-runner and code consumers.
* Move the JSDOM dependency to the script. * Add some error-handling to the script. * Add help info to the script. * Support specifying a container element ID, or not, in the script.
This was referenced Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for converting from JSON to HTML and from HTML to JSON, to be used by the splash page/script so that a splash page can be created on which the Landmarks scripts can run.
In support of #165