Shortcut to toggle display of all landmarks (with labels)? #120
Comments
|
How will this work when headings are supported? Even more shortcut keys, or use it as a toggle? Plus: how will it be represented in the UI? Currently it could be a simple toggle button in the browser pop-up, but what about when headings are supported too—two toggle buttons? In which case how does that play with a single keyboard shortcut to toggle between four states (landmarks/headings/both/neither)? The best place to do state management may be in a separate object in the content script. Need to check if it's possible to update the pop-up with extra info once it's open. |
|
Bumping to a later release, as already added some interesting stuff to 2.4.0 (DevTools for all, and sidebar for some), and it would be good to ship it. This will require removing the partly-defined "show all" command from 2.4.0, so leaving this assigned to 2.4.0 for now. |
Naughty! This really should’ve been split up into smaller PRs, though I think I am starting to get into this new commit style :-). Anyway, this does a couple of things: * Adds help page support for indicating to the user when a keyboard shortcut is not set (in support of #165). * Implements a keyboard shortcut that toggles the display of all landmarks (in support of #120). In support of this, it required splitting the ElementFocuser into an ElementFocuser and a BorderDrawer. A lot of API naming cleanup and code tidying was done too. A further PR will add UI to the pop-up that mouse users can use to access this feature.
Add a UI toggle to allow the user to show all landmarks that way too, and to reflect whether they are currently all being shown. Closes #120.
Particularly if they're to be labelled, having this sort of overview view may be nice (especially for auditing pages, though that should not get in the way of ensuring the extension is easy to use for its main focus of helping users navigate).
The text was updated successfully, but these errors were encountered: