Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image publish workflow #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ctkcoding
Copy link

Added a workflow to publish docker images to github and dockerhub using the existing Dockerfile.

@sirodoht sirodoht changed the title add docker image publish workflow Add docker image publish workflow Mar 30, 2024
@sirodoht sirodoht added the enhancement New feature or request label Mar 30, 2024
@sirodoht
Copy link
Member

Hey @ctkcoding! I'm not using Docker and I don't have an account at Docker Hub, so I will postpone exploring this further for the time being as I'm not sure how useful it could be :)

Thanks for suggesting it in any case!

@ctkcoding
Copy link
Author

I find it really useful to have a docker artifact to pull instead of source code with extra config re subdomains etc like in the ticket that I raised yesterday, and it will probably need a few extra changes to handle that setup. I will take a look at doing that and cut the Docker Hub flow if you don't have an account and leave the part that auto publishes to github's container registry when you create releases which it looks like you're already doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants