Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the CI clean and build (instead of just clean) (IOS-280) #1311

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Make the CI clean and build (instead of just clean) (IOS-280) #1311

merged 3 commits into from
Jun 11, 2024

Conversation

zeitschlag
Copy link
Contributor

No description provided.

@zeitschlag zeitschlag marked this pull request as ready for review June 11, 2024 10:07
@zeitschlag zeitschlag changed the title [WIP] Fix CI Make the CI clean and build (instead of just clean) (IOS-280) Jun 11, 2024
@zeitschlag zeitschlag requested a review from kimar June 11, 2024 10:08
kimar
kimar approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@kimar kimar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I would have expected for build: true to be the default in xcodebuild. Good catch!

@zeitschlag zeitschlag merged commit 3737005 into develop Jun 11, 2024
3 checks passed
@zeitschlag zeitschlag deleted the issue-ios-280-fix-ci branch June 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimar kimar kimar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeitschlag @kimar