Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 💊-Issues #1278

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix 💊-Issues #1278

merged 2 commits into from
Apr 23, 2024
+10 −2

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Apr 22, 2024 •
edited
Loading

  • When switching the timelines, the pill appeared with "New Posts!!!!!!" which makes sense but also it doesn't.
  • When scrolling to the top, the pill didn't disappear. This annoyed me so I made it go away when timeline was scrolled to top.

Fixes #1275.

@zeitschlag zeitschlag marked this pull request as ready for review April 23, 2024 07:14
@zeitschlag zeitschlag requested a review from kimar April 23, 2024 07:14
kimar
kimar approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kimar kimar merged commit cdced03 into develop Apr 23, 2024
2 checks passed
@kimar kimar deleted the 1275-pill-issues branch April 23, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimar kimar kimar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💊 -Issues
2 participants
@zeitschlag @kimar